tui/tabbar: Prevent closing the last remaining tab#1790
Merged
dgageot merged 1 commit intodocker:mainfrom Feb 19, 2026
Merged
Conversation
Ignore close tab key (Ctrl+W) when only one tab remains open. This prevents accidentally clearing the current session and preserves muscle memory for users who expect Ctrl+W to delete the last word in single-tab scenarios. Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
vvoland
force-pushed
the
ctrlwlasttab
branch
from
f24eb5c to
d301d13
Compare
![docker-agent[bot]](https://avatars.githubusercontent.com/in/2787757?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Summary
✅ No issues found in the changed code.
The logic change from len(t.tabs) == 0 to len(t.tabs) <= 1 correctly implements the stated goal of preventing the last remaining tab from being closed. The condition properly handles both the edge case of 0 tabs and the main scenario of 1 tab, returning nil (no-op) in both cases.
krissetto
approved these changes
Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ignore close tab key (Ctrl+W) when only one tab remains open.
This prevents accidentally clearing the current session and preserves muscle memory for users who expect Ctrl+W to delete the last word in single-tab scenarios.